oss/Portal
1
0
Fork 0
Code Issues 1 Pull requests 3 Projects Releases 1 Packages Wiki Activity

fix(deps): egui/eframe 0.31->0.35 migration #8

Closed
oss wants to merge 2 commits from renovate-fix/egui-035 into main
pull from: renovate-fix/egui-035
merge into: oss:main
Conversation 1 Commits 2 Files changed 3 +755 -521
oss commented 2026-07-05 01:25:31 +02:00
Owner
Copy link

egui/eframe 0.31->0.35 API migration in src/app.rs (new ui() entry point, unified egui::Panel, screen_rect->content_rect, on_exit signature). ssh2-config 0.6->0.7 needed no code changes. Cargo.lock regenerated. Verified: cargo build --release clean (0 warnings), cargo test compiles+passes (no unit tests exist). Supersedes #2.

REVIEW NOTES: (1) GUI runtime not exercised � a manual launch to confirm panel layout is worthwhile. (2) The base renovate/non-major branch predates the already-merged dirs v6 (#7) and shows dirs 6->5; rebase on current main before merging so dirs stays at 6. Prepared by a fable subagent.

egui/eframe 0.31->0.35 API migration in src/app.rs (new ui() entry point, unified egui::Panel, screen_rect->content_rect, on_exit signature). ssh2-config 0.6->0.7 needed no code changes. Cargo.lock regenerated. Verified: cargo build --release clean (0 warnings), cargo test compiles+passes (no unit tests exist). Supersedes #2. **REVIEW NOTES:** (1) GUI runtime not exercised � a manual launch to confirm panel layout is worthwhile. (2) The base renovate/non-major branch predates the already-merged dirs v6 (#7) and shows dirs 6->5; **rebase on current main before merging so dirs stays at 6.** Prepared by a fable subagent.
Update non-major
Some checks failed
renovate/artifacts Artifact file update failure
18a9a57dc4 
Fix compile errors from the Renovate non-major bump (eframe/egui_extras
0.31 -> 0.35, ssh2-config 0.6 -> 0.7):

- eframe::App: rename update(ctx, frame) to ui(&mut Ui, frame); derive
  the Context via ui.ctx() and thread &mut Ui through the view functions
- on_exit: drop the Option<&glow::Context> parameter (glow feature is no
  longer enabled by default)
- Panels: SidePanel/TopBottomPanel are unified into egui::Panel
  (left/right/bottom); default_width/min_width/max_width/min_height
  become default_size/min_size/max_size; panels now show inside the
  root Ui instead of the Context
- CentralPanel::show now takes &mut Ui instead of &Context
- ctx.screen_rect() is replaced by ctx.content_rect()

ssh2-config 0.7 needed no call-site changes. Cargo.lock regenerated for
the new dependency tree.
oss commented 2026-09-08 07:26:07 +02:00
Author
Owner
Copy link

Superseded: main now carries eframe/egui_extras 0.36 (83e5f99), ssh2-config 0.8 (da6c37d), and dirs 7 plus russh 0.63 (6257714). The 0.35 migration from this branch was ported onto main as part of that.

Superseded: main now carries eframe/egui_extras 0.36 (83e5f99), ssh2-config 0.8 (da6c37d), and dirs 7 plus russh 0.63 (6257714). The 0.35 migration from this branch was ported onto main as part of that.
oss closed this pull request 2026-09-08 07:26:07 +02:00

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
oss/Portal!8
No description provided.